[PATCH] D102707: Fix non-global-value-max-name-size not considered by LLParser

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: llvm/include/llvm/IR/ValueSymbolTable.h:78
+    // lookup will fail if Name exceeds the size cap.
+    return vmap.lookup(capLocalValueName(Name));
+  }
----------------
The fact that the table lookups would automatically use this but not the insertions looks like a red flag to me. If this is an invariant of the table then it should be private the table and reflected by the API consistently.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102707/new/

https://reviews.llvm.org/D102707