[PATCH] D101919: RISCV: add a few deprecated aliases for CSRs

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd marked 2 inline comments as done.
compnerd added inline comments.


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1318
+        Warning(S, "'" + Identifier + "' is a deprecated alias for '" +
+                       SysReg->Name + "'");
+
----------------
craig.topper wrote:
> craig.topper wrote:
> > Shouldn't this be aligned with the "'" on the previous line or did clang-format get confused somehow?
> Nevermind I guess, that's actually clang-format indenting it by 4 spaces?
Yeah, this is what clang-format wants.


================
Comment at: llvm/lib/Target/RISCV/RISCVSystemOperands.td:25
+  // A maximum of one deprecated name is supported right now.
+  string DeprecatedName = "";
+  bits<12> Encoding = op;
----------------
craig.topper wrote:
> Should we document that DeprecatedName emits a warning? AltName appears to also be used for older names.
Ah, good idea.  I'll update the comment (can do that right before committing).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101919/new/

https://reviews.llvm.org/D101919