[PATCH] D101919: RISCV: add a few deprecated aliases for CSRs

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1318
+        Warning(S, "'" + Identifier + "' is a deprecated alias for '" +
+                       SysReg->Name + "'");
+
----------------
Shouldn't this be aligned with the "'" on the previous line or did clang-format get confused somehow?


================
Comment at: llvm/lib/Target/RISCV/RISCVSystemOperands.td:25
+  // A maximum of one deprecated name is supported right now.
+  string DeprecatedName = "";
+  bits<12> Encoding = op;
----------------
Should we document that DeprecatedName emits a warning? AltName appears to also be used for older names.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101919/new/

https://reviews.llvm.org/D101919