[PATCH] D102709: [MCA] llvm-mca MCTargetStreamer segfault fix

Patrick Holland via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 19 13:19:39 PDT 2021


holland11 added a comment.

In D102709#2769357 <https://reviews.llvm.org/D102709#2769357>, @andreadb wrote:

> In D102709#2769266 <https://reviews.llvm.org/D102709#2769266>, @holland11 wrote:
>
>> @andreadb I seem to have made a mistake with the test file which is causing the commit to fail. I didn't realize I needed to explicitly declare the cpu (-mcpu= argument). I just looked at all of the other tests in the X86 directory and I will be modifying my test file then re-submitting as a new diff. Sorry about that.
>
> Hey Patrick,
>
> don't worry about it. It is already fixed here: https://reviews.llvm.org/rG9acabe8b6ff5
>
> I was keeping an eye at the buildbot page, and I saw the failures after your commit. It is all fixed now :)

Awesome! Thank you for that. I'm working on llvm-mca currently and I'm sure I could benefit from your insight occasionally if there's a way to reach you directly? (Maybe discord?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102709/new/

https://reviews.llvm.org/D102709



More information about the llvm-commits mailing list