[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

[Masoud Ataei via Phabricator via llvm-commits]

masoud.ataei added inline comments.


================
Comment at: llvm/include/llvm/Analysis/ScalarFuncs.def:17
+
+TLI_DEFINE_SCALAR_MASS_FUNC("acosf", "__xl_acosf_finite")
+TLI_DEFINE_SCALAR_MASS_FUNC("__acosf_finite", "__xl_acosf_finite")
----------------
bmahjour wrote:
> shouldn't these map from llvm.* intrinsics to mass entry points as well?
llvm intrinsics is handled in `PPCISelLowering.cpp`.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:1361
   setLibcallName(RTLIB::FMA_F128, "fmaf128");
+  if (TM.Options.PPCGenScalarMASSEntries && TM.Options.UnsafeFPMath) {
+    setLibcallName(RTLIB::COS_F64, "__xl_cos_finite");
----------------
bmahjour wrote:
> why are these being handled here instead of `PPCGenScalarMASSEntries.cpp`?
We are not handling llvm intrinsics in `PPCGenScalarMASSEntries.cpp` because we don't want to block any type of existing optimizations (like pow(x,0.5) --> sqrt(x)) and future optimizations (like https://reviews.llvm.org/D94543 ?).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101759/new/

https://reviews.llvm.org/D101759