[PATCH] D102634: Calculate indexes of last child of each DWARF entry once during tryExtractDIEsIfNeeded.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 19 11:21:12 PDT 2021


dblaikie added a comment.

In D102634#2767781 <https://reviews.llvm.org/D102634#2767781>, @simon.giesecke wrote:

> In D102634#2766582 <https://reviews.llvm.org/D102634#2766582>, @dblaikie wrote:
>
>> What's your use case such that this performance concern has come up for you?
>
> It's a hotspot when running `llvm-gsymutil --convert`. I can provide some numbers if you want.

If you happen to have them, might be nice to have in the patch description/commit message.

(@clayborg's suggestion of replacing "Depth" with two smaller fields seems roughly plausible to me/reasonable thing to try, for what it's worth)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102634/new/

https://reviews.llvm.org/D102634



More information about the llvm-commits mailing list