[PATCH] D102745: [OpaquePtr] Make cmpxchg work with opaque pointers

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 19 11:18:54 PDT 2021


dblaikie added inline comments.


================
Comment at: llvm/lib/IR/Verifier.cpp:3854-3856
   Assert(ElTy == CXI.getOperand(2)->getType(),
-         "Stored value type does not match pointer operand type!", &CXI, ElTy);
+         "Stored value type does not match expected value operand type!", &CXI,
+         ElTy);
----------------
Is there missing testing for this? Looks like the wording/assert was changed, but no test cases were updated for this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102745/new/

https://reviews.llvm.org/D102745



More information about the llvm-commits mailing list