[PATCH] D102754: [unittests][CodeGen] Mark tests that cannot be executed with GTEST_SKIP()

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 19 10:24:56 PDT 2021


scott.linder added a comment.

I see `// TODO: Use GTEST_SKIP() when GTest is updated to version 1.10.0` show up in `llvm/unittests/CodeGen/DIEHashTest.cpp`, `llvm/unittests/ExecutionEngine/Orc/OrcCAPITest.cpp` and `clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp`; would you consider updating those at the same time?

Other than that this LGTM, thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102754/new/

https://reviews.llvm.org/D102754



More information about the llvm-commits mailing list