[PATCH] D100672: [ADT] Add new type traits for type pack indexes

[Scott Linder via Phabricator via llvm-commits]

scott.linder added a comment.

In D100672#2768909 <https://reviews.llvm.org/D100672#2768909>, @stella.stamenova wrote:

> @dblaikie @scott.linder I updated VS on both the mlir and lldb windows buildbots (from 15.9.30 to 15.9.36), but this update does not have an update to the compiler and indeed the compiler version was already ```Microsoft (R) C/C++ Optimizing Compiler Version 19.16.27045```. You can see from the logs of the broken builds as well:
>
>   -- The C compiler identification is MSVC 19.16.27045.0
>   -- The CXX compiler identification is MSVC 19.16.27045.0
>
> I think the issue is rather C++ 14 vs. C++ 17. It is my understanding that C++ 14 is required for LLVM, but not C++ 17, is that the case?

That's my understanding too, but even adding `/std:c++14` to the command-line doesn't cause the failure, at least on godbolt: https://godbolt.org/z/zPTGjMsKa

I'm not sure what to make of it now, and I'm not particularly familiar with Windows or MSVC. I'm still amenable to changing the code, but I also fear the changes I made won't actually fix the issue as I am only testing on godbolt. Is there any shortcut to testing with the Windows buildbots? Or do I have to install Windows somewhere and try to reproduce it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100672/new/

https://reviews.llvm.org/D100672