[PATCH] D101538: [GlobalISel][IRTranslator] Make translate() methods virtual.

Wed May 19 08:50:25 PDT 2021

zuban32 added a comment.

In D101538#2768105 <https://reviews.llvm.org/D101538#2768105>, @foad wrote:

>>> Won't this problem go away when we introduce FP LLTs?
>>
>> I wouldn't be so sure about that. One particular usecase I need this for is a bitcast between pointer types:
>>
>>   %1 = bitcast i8* %0 to %struct.ST*
>>
>> In our target they're both of p0 LLTs, so the default method eliminates this instruction while in our target it's necessary to keep it.
>
> What are you going to do when IR switches to opaque pointers? https://llvm.org/docs/OpaquePointers.html

Good point, an honest answer would be "We haven't thought about it yet" :) BTW is there any exact timeline of the switch? I saw some related patches sent, but not sure when that's going to happen

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101538/new/

https://reviews.llvm.org/D101538