[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

Wed May 19 07:35:18 PDT 2021

stevewan added a comment.

Might be a dumb question, but I see this is a revert to rGb116ded <https://reviews.llvm.org/rGb116ded57da3530e661f871f4191c59cd9e091cd>, do we also want to revert the changes added to `llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp`?

================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4964
   if (!RawTriple.isOSDarwin() && !RawTriple.isNVPTX() &&
-      !RawTriple.isAMDGPU() && !RawTriple.isOSAIX())
+      !RawTriple.isAMDGPU())
     CmdArgs.push_back("-mconstructor-aliases");
----------------
jasonliu wrote:
> Format as clang-format suggest. You could run clang-format or git-clang-format just for your commits by the way. 
FWIW, if `clang-format` is installed on your host (you can do this via homebrew on mac IIRC), arc would use it as the linter when you do `arc lint` or `arc diff`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102724/new/

https://reviews.llvm.org/D102724