[PATCH] D102224: Add option to llvm-gsymutil to read addresses from stdin.
Simon Giesecke via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 19 04:01:48 PDT 2021
simon.giesecke added inline comments.
================
Comment at: llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp:501
+ while (fgets(InputString, sizeof(InputString), stdin)) {
+ // Strip newline characters.
+ std::string StrippedInputString(InputString);
----------------
clayborg wrote:
> Can we use C++ STL here? Or there might be some other LLVM tools that use STDIN using some other LLVM input wrapping?
>
> ```
> std::string line;
> std::getline(std::cin, line);
> ````
>
I copied this from `llvm-symbolizer` but I can surely change this to use STL. I can also use some other LLVM tools, but would need some guidance.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102224/new/
https://reviews.llvm.org/D102224
More information about the llvm-commits
mailing list