[PATCH] D102753: [LLParser] Remove outdated deplibs

[Xuanda Yang via Phabricator via llvm-commits]

TH3CHARLie created this revision.
TH3CHARLie added a reviewer: alok.
Herald added a subscriber: hiraditya.
TH3CHARLie requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The comment dated 9 years ago mentions deplibs should be removed in 4.0. Removing it in this patch.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D102753

Files:
  llvm/include/llvm/AsmParser/LLParser.h
  llvm/lib/AsmParser/LLLexer.cpp
  llvm/lib/AsmParser/LLParser.cpp


Index: llvm/lib/AsmParser/LLParser.cpp
===================================================================
--- llvm/lib/AsmParser/LLParser.cpp
+++ llvm/lib/AsmParser/LLParser.cpp
@@ -356,10 +356,6 @@
       if (parseModuleAsm())
         return true;
       break;
-    case lltok::kw_deplibs:
-      if (parseDepLibs())
-        return true;
-      break;
     case lltok::LocalVarID:
       if (parseUnnamedType())
         return true;
@@ -459,29 +455,6 @@
   return false;
 }
 
-/// toplevelentity
-///   ::= 'deplibs' '=' '[' ']'
-///   ::= 'deplibs' '=' '[' STRINGCONSTANT (',' STRINGCONSTANT)* ']'
-/// FIXME: Remove in 4.0. Currently parse, but ignore.
-bool LLParser::parseDepLibs() {
-  assert(Lex.getKind() == lltok::kw_deplibs);
-  Lex.Lex();
-  if (parseToken(lltok::equal, "expected '=' after deplibs") ||
-      parseToken(lltok::lsquare, "expected '=' after deplibs"))
-    return true;
-
-  if (EatIfPresent(lltok::rsquare))
-    return false;
-
-  do {
-    std::string Str;
-    if (parseStringConstant(Str))
-      return true;
-  } while (EatIfPresent(lltok::comma));
-
-  return parseToken(lltok::rsquare, "expected ']' at end of list");
-}
-
 /// parseUnnamedType:
 ///   ::= LocalVarID '=' 'type' type
 bool LLParser::parseUnnamedType() {
Index: llvm/lib/AsmParser/LLLexer.cpp
===================================================================
--- llvm/lib/AsmParser/LLLexer.cpp
+++ llvm/lib/AsmParser/LLLexer.cpp
@@ -543,7 +543,6 @@
   KEYWORD(triple);
   KEYWORD(source_filename);
   KEYWORD(unwind);
-  KEYWORD(deplibs);             // FIXME: Remove in 4.0.
   KEYWORD(datalayout);
   KEYWORD(volatile);
   KEYWORD(atomic);
Index: llvm/include/llvm/AsmParser/LLParser.h
===================================================================
--- llvm/include/llvm/AsmParser/LLParser.h
+++ llvm/include/llvm/AsmParser/LLParser.h
@@ -301,7 +301,6 @@
     bool parseTargetDefinition();
     bool parseModuleAsm();
     bool parseSourceFileName();
-    bool parseDepLibs(); // FIXME: Remove in 4.0.
     bool parseUnnamedType();
     bool parseNamedType();
     bool parseDeclare();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102753.346367.patch
Type: text/x-patch
Size: 2156 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210519/d223696d/attachment.bin>