[PATCH] D102707: Fix non-global-value-max-name-size not considered by LLParser

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 19 02:20:44 PDT 2021


serge-sans-paille added inline comments.


================
Comment at: llvm/lib/AsmParser/LLParser.cpp:3122
+  // lookup will fail if Name exceeds the size cap.
+  Value *Val = F.getValueSymbolTable()->lookup(capLocalValueName(Name));
 
----------------
This is starting to looks like an invariant that should be maintained (or at least checked) by the value symbol table itself, instead of being enforced at callsite. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102707/new/

https://reviews.llvm.org/D102707



More information about the llvm-commits mailing list