[PATCH] D93838: [SCCP] Add Function Specialization pass

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu added a comment.

I am wondering if we can remove original IPSCCP once we made this strong enough?



================
Comment at: llvm/lib/Transforms/Scalar/FunctionSpecialization.cpp:432-438
+    // If the argument isn't overdefined, there's nothing to do. It should
+    // already be constant.
+    if (!Solver.getLatticeValueFor(A).isOverdefined()) {
+      LLVM_DEBUG(dbgs() << "FnSpecialization: nothing to do, arg is already "
+                        << "constant?\n");
+      return false;
+    }
----------------
It looks like we left this work to original IPSCCP to handle. Can we make it in this pass?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93838/new/

https://reviews.llvm.org/D93838