[PATCH] D102665: [llvm-objcopy] Add support for '--' for delimiting options from input/output files

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one suggestion.



================
Comment at: llvm/test/tools/llvm-objcopy/dash-dash.test:12
+## Check the case when '--' is specified with input files but no options.
+# RUN: llvm-objcopy test-obj -- --add-section
+# RUN: llvm-objcopy test-obj out-obj2
----------------
I'd put the `--` before `test-obj` here. That way, you have coverage for all positional arguments being after the `--`. It also removes the potential for positional arguments either side of the `--` treating the first as an option (in terms of whether the lack of options is an issue).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102665/new/

https://reviews.llvm.org/D102665