[PATCH] D102601: [NFC][object] Change the input parameter of the method isDebugSection.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 19 00:46:21 PDT 2021


jhenderson added inline comments.


================
Comment at: llvm/lib/Object/COFFObjectFile.cpp:335
+    // TODO: Report the error message properly.
+    consumeError(SectionNameOrErr.takeError());
+  }
----------------
You need to return after this `consumeError`, as you can't safely retrieve the name from a failed Expected. Same applies in the other file formats.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102601/new/

https://reviews.llvm.org/D102601



More information about the llvm-commits mailing list