[PATCH] D41296: Limit size of non-GlobalValue name

Tue May 18 21:00:35 PDT 2021

uabelho added a comment.

In D41296#1607583 <https://reviews.llvm.org/D41296#1607583>, @aaronpuchert wrote:

> In D41296#962215 <https://reviews.llvm.org/D41296#962215>, @hfinkel wrote:
>
>> Why don't we just cap all names at some point (and then just start adding numbers as we generally do to break degeneracies). It seems like, otherwise, we'll end up with these kinds of fixes in many places. Fixing this in one common place seems better.
>
> This change has the unfortunate side effect of creating unexpected error messages in the LLParser that have been observed in software using LLVM <https://github.com/numba/numba/issues/3669>. Reading the discussion here does not indicate that this effect was intended.
>
> It can even lead to cases where we can't read our own output. To see how this happens, let's simulate a much smaller limit of 4. The normal output of the test case would have been (I've stripped the metadata here):

I think the above problem is similar to what is described in
 https://bugs.llvm.org/show_bug.cgi?id=45899

There is a patch trying to address it:
 https://reviews.llvm.org/D102707

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D41296/new/

https://reviews.llvm.org/D41296