[PATCH] D102594: [NFCI] Move DEBUG_TYPE definition below #include of headers
Mindong Chen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 18 18:07:46 PDT 2021
mdchen added a comment.
In D102594#2766167 <https://reviews.llvm.org/D102594#2766167>, @tejohnson wrote:
> lgtm. this seems fine to me, but presumably we would have a compile error if there was ever a conflict in practice with one of these files?
In practice it conflicts with macros defined in header files; if a conflict header file defines one but doesn't undefined it(which is unusual), the compiler throws a redefinition warning; in a general case, there'll be a compile error instead. Thanks for the review!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102594/new/
https://reviews.llvm.org/D102594
More information about the llvm-commits
mailing list