[PATCH] D102736: Fix tmp files being left on Windows builds.

[Adrian McCarthy via Phabricator via llvm-commits]

amccarth added a comment.

I'll have to dig into my archived email tomorrow.

I seem to recall some thrashing on this topic a few months ago.  If I'm remembering correctly, setting the disposition to delete temporary files on Windows was causing problems with Rust builds because you can't always set the delete disposition (e.g., for a file on a network drive).  I think it got pulled out, and then put back in in a limited way.

It certainly would be nice to clean up temporaries left because of a crash, but it's even better not to crash. :-)  Lots of programs will leave partially written files if they die unexpectedly, and sometimes they can be useful when figuring out what happened.  Part of me wonders whether we should reclaim orphaned temporaries on the next run instead.  That might not be hard if we had a predictable location and naming scheme.

Another crazy idea would be to have the driver sit idly while the compiler and linker do their thing, and then clean up behind them if necessary.

Tests, however, always need to be cleaned up one way or another.

I'll take a closer look in the morning.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102736/new/

https://reviews.llvm.org/D102736