[PATCH] D102732: [CMake] Don't LTO optimize targets that aren't part of any distribution

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added inline comments.


================
Comment at: llvm/cmake/modules/LLVMDistributionSupport.cmake:59-62
+# Look up the distribution a particular target belongs to. By convention, the
+# project calling this should set the ${PROJECT}${distribution}_HAS_EXPORTS
+# global property to true if the target is in ${distribution} (${PROJECT} is the
+# project name in uppercase).
----------------
The second sentence of this comment "By convention, ..." should be removed ... that's handled by get_target_export_arg now.


================
Comment at: llvm/cmake/modules/LLVMDistributionSupport.cmake:132
       set_property(GLOBAL PROPERTY ${project_upper}_${distribution_upper}_HAS_EXPORTS True)
     endif()
   else()
----------------
I think we need an `else` here to preserve the previous behavior of this function?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102732/new/

https://reviews.llvm.org/D102732