[PATCH] D102452: [Remarks] Add analysis remarks for memset/memcpy/memmove lengths

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg accepted this revision.
thegameg added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/Transforms/Utils/MemoryOpRemark.h:48
+  /// \return true iff MemoryOpRemark can describe this instruction.
+  static bool describes(const Instruction *I);
+
----------------
Nit: I am not sure if `describe` is the best fit here. I used `inspect` in other places which is probably even worse now that I'm looking back. Maybe something like `canHandle`?


================
Comment at: llvm/lib/Transforms/Utils/MemoryOpRemark.cpp:115
+  if (Inline && *Inline)
+    R << " Inline: " << NV("StoreInline", true) << ".";
   if (Volatile)
----------------
Maybe "Inline**d**" is better?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102452/new/

https://reviews.llvm.org/D102452