[PATCH] D102391: [AMDGPU][GlobalISel] Legalize G_ABS

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.abs.ll:42-44
+; GFX-NEXT:    s_cselect_b32 s4, 1, 0
+; GFX-NEXT:    s_and_b32 s4, s4, 1
+; GFX-NEXT:    s_cmp_lg_u32 s4, 0
----------------
foad wrote:
> Not really related to your patch, but this sequence needs cleaning up. The s_and is redundant, and the s_cmp just computes the same scc value that s_add computed in the first place.
This is probably a consequence of not having a pass to minimize scc/physreg liveranges


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102391/new/

https://reviews.llvm.org/D102391