[PATCH] D102523: [docs] Explain address spaces a bit more in opaque pointers doc

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 18 13:55:13 PDT 2021


aeubanks updated this revision to Diff 346269.
aeubanks added a comment.

make more explicit that opaque pointers aren't changing lowering


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102523/new/

https://reviews.llvm.org/D102523

Files:
  llvm/docs/OpaquePointers.rst


Index: llvm/docs/OpaquePointers.rst
===================================================================
--- llvm/docs/OpaquePointers.rst
+++ llvm/docs/OpaquePointers.rst
@@ -14,7 +14,11 @@
 pointee types in LLVM with an opaque pointer type. The new pointer type is
 tentatively represented textually as ``ptr``.
 
-Anything to do with pointer address spaces is unaffected.
+Address spaces are still used to distinguish between different kinds of pointers
+where the distinction is relevant for lowering (e.g. data vs function pointers
+have different sizes on some architectures). Opaque pointers are not changing
+anything related to address spaces and lowering. For more information, see
+`DataLayout <LangRef.html#langref-datalayout>`_.
 
 Issues with explicit pointee types
 ==================================


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102523.346269.patch
Type: text/x-patch
Size: 814 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210518/27dd4bbe/attachment.bin>


More information about the llvm-commits mailing list