[PATCH] D102713: [PDB] Improve error handling when writes fail

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

In D102713#2766856 <https://reviews.llvm.org/D102713#2766856>, @aganea wrote:

> Strangely, a few weeks ago I had a similair issue while trying to link an executable with MSVC-built .OBJ files. My PDB with `lld-link.exe` would have been 7.7 GB, but when linking the same .OBJ files with `link.exe` the PDB is 2.7 GB. Since we moved off MSVC, I haven't investigated in detail why. The problem doesn't occur on the same target when using Clang. I'm curious, is that your case?
>
> In any case, LTGM.

Yes, our PDBs end up getting too big when we use either coverage (https://crbug.com/1159468) or static O0 builds (https://crbug.com/1179085). I think the common denominator between those two build configs is that they do not delete trivial inline functions, so you end up with standalone definitions of every little helper like `std::unique_ptr<>::get()`, and that somehow adds up to more than if those things were inlined everywhere.

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102713/new/

https://reviews.llvm.org/D102713