[PATCH] D102710: [NFC][test] replace empty returns with GTEST_SKIP

[Mats Larsen via Phabricator via llvm-commits]

supergrecko created this revision.
supergrecko added a reviewer: lhames.
supergrecko requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Now that gtest has been updated to 1.10 which supports GTEST_SKIP, we can use that over return;

This patch replaces returns with GTEST_SKIP for the todo listings added in https://reviews.llvm.org/rGd122d80b3d1c3ffdfbf6a2168f3d61fa4337facc


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D102710

Files:
  llvm/unittests/ExecutionEngine/Orc/OrcCAPITest.cpp


Index: llvm/unittests/ExecutionEngine/Orc/OrcCAPITest.cpp
===================================================================
--- llvm/unittests/ExecutionEngine/Orc/OrcCAPITest.cpp
+++ llvm/unittests/ExecutionEngine/Orc/OrcCAPITest.cpp
@@ -220,8 +220,7 @@
 
 TEST_F(OrcCAPITestBase, SymbolStringPoolUniquing) {
   if (!Jit) {
-    // TODO: Use GTEST_SKIP() when GTest is updated to version 1.10.0
-    return;
+    GTEST_SKIP();
   }
 
   LLVMOrcSymbolStringPoolEntryRef E1 =
@@ -241,8 +240,7 @@
 
 TEST_F(OrcCAPITestBase, JITDylibLookup) {
   if (!Jit) {
-    // TODO: Use GTEST_SKIP() when GTest is updated to version 1.10.0
-    return;
+    GTEST_SKIP();
   }
   LLVMOrcJITDylibRef DoesNotExist =
       LLVMOrcExecutionSessionGetJITDylibByName(ExecutionSession, "test");
@@ -256,8 +254,7 @@
 
 TEST_F(OrcCAPITestBase, MaterializationUnitCreation) {
   if (!Jit) {
-    // TODO: Use GTEST_SKIP() when GTest is updated to version 1.10.0
-    return;
+    GTEST_SKIP();
   }
 
   LLVMOrcSymbolStringPoolEntryRef Name =
@@ -279,8 +276,7 @@
 
 TEST_F(OrcCAPITestBase, DefinitionGenerators) {
   if (!Jit) {
-    // TODO: Use GTEST_SKIP() when GTest is updated to version 1.10.0
-    return;
+    GTEST_SKIP();
   }
 
   LLVMOrcDefinitionGeneratorRef Gen =
@@ -298,8 +294,7 @@
 
 TEST_F(OrcCAPITestBase, ResourceTrackerDefinitionLifetime) {
   if (!Jit) {
-    // TODO: Use GTEST_SKIP() when GTest is updated to version 1.10.0
-    return;
+    GTEST_SKIP();
   }
 
   // This test case ensures that all symbols loaded into a JITDylib with a
@@ -328,8 +323,7 @@
 
 TEST_F(OrcCAPITestBase, ResourceTrackerTransfer) {
   if (!Jit) {
-    // TODO: Use GTEST_SKIP() when GTest is updated to version 1.10.0
-    return;
+    GTEST_SKIP();
   }
 
   LLVMOrcResourceTrackerRef DefaultRT =
@@ -352,8 +346,7 @@
 
 TEST_F(OrcCAPITestBase, AddObjectBuffer) {
   if (!Jit) {
-    // TODO: Use GTEST_SKIP() when GTest is updated to version 1.10.0
-    return;
+    GTEST_SKIP();
   }
 
   LLVMOrcObjectLayerRef ObjLinkingLayer = LLVMOrcLLJITGetObjLinkingLayer(Jit);
@@ -373,8 +366,7 @@
 
 TEST_F(OrcCAPITestBase, ExecutionTest) {
   if (!Jit) {
-    // TODO: Use GTEST_SKIP() when GTest is updated to version 1.10.0
-    return;
+    GTEST_SKIP();
   }
 
   using SumFunctionType = int32_t (*)(int32_t, int32_t);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102710.346239.patch
Type: text/x-patch
Size: 2299 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210518/20663ef7/attachment.bin>