[PATCH] D102436: [lld][WebAssembly] Enable string merging for debug sections

[Derek Schuff via Phabricator via llvm-commits]

dschuff accepted this revision.
dschuff added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/wasm/InputChunks.h:68
   uint64_t getOffset(uint64_t offset) const;
-  // For data segments, translate and offset into the input segment into
-  // an offset into the output segment
-  uint64_t getSegmentOffset(uint64_t offset) const;
+  // For data segments translate and offset into the input segment into
+  // and offset into the output segment
----------------



================
Comment at: lld/wasm/InputChunks.h:68
   uint64_t getOffset(uint64_t offset) const;
-  // For data segments, translate and offset into the input segment into
-  // an offset into the output segment
-  uint64_t getSegmentOffset(uint64_t offset) const;
+  // For data segments translate and offset into the input segment into
+  // and offset into the output segment
----------------
dschuff wrote:
> 
Actually, does this comment now also apply to custom sections as well as data segments?


================
Comment at: lld/wasm/InputChunks.h:69
+  // For data segments translate and offset into the input segment into
+  // and offset into the output segment
+  uint64_t getChunkOffset(uint64_t offset) const;
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102436/new/

https://reviews.llvm.org/D102436