[PATCH] D102419: [MinGW] Always enable -mbig-obj for LLVM build unless using Clang

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 18 11:37:57 PDT 2021


mstorsjo added inline comments.


================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:415
+  # Pass -mbig-obj to mingw gas to avoid COFF 2**16 section limit.
+  if (NOT CLANG)
     append("-Wa,-mbig-obj" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
----------------
mati865 wrote:
> I did not regenerate CMake files properly between runs.
> This line should actually read: `if (NOT CMAKE_CXX_COMPILER_ID MATCHES "Clang")`.
> 
> I'm sorry for that.
Ok, I'll push a correction a bit later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102419/new/

https://reviews.llvm.org/D102419



More information about the llvm-commits mailing list