[PATCH] D102667: [MSan] Set zeroext on call arguments to msan functions with zeroext parameter attribute

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 18 11:24:15 PDT 2021


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:1184
+               IRB.CreatePointerCast(Addr, IRB.getInt8PtrTy()), Origin});
+      CB->addAttribute(AttributeList::FirstArgIndex, Attribute::ZExt);
+      CB->addAttribute(AttributeList::FirstArgIndex + 2, Attribute::ZExt);
----------------
I suggest `CB->addParamAttr` as a shorter spelling for the same stuff. I noticed DFSan does it that way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102667/new/

https://reviews.llvm.org/D102667



More information about the llvm-commits mailing list