[PATCH] D102686: [VP] getDeclarationForParams

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/IR/IntrinsicInst.cpp:393
+  // works for binary arithmetic VP intrinsics.
+  Value &FirstOp = *Params[0];
+  using ShortTypeVec = SmallVector<Type *, 1>;
----------------
Is this written this way because of the TODO? It seems like this could just be

```
auto *VPFunc = Intrinsic::getDeclaration(M, VPID, Params[0]->getType());
```

Which avoids the SmallVector.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102686/new/

https://reviews.llvm.org/D102686