[PATCH] D101916: [LoopVectorize] Fix crash for predicated instructions with scalable VF

[David Sherwood via Phabricator via llvm-commits]

david-arm accepted this revision.
david-arm added a comment.
This revision is now accepted and ready to land.

LGTM! Looks like you've addressed all the review comments. :)



================
Comment at: llvm/test/Transforms/LoopVectorize/scalable-predicate-instruction.ll:6
+
+; This check this cpp function
+;   for (long long i = 0; i < n; i++) {
----------------
nit: Maybe "This test corresponds to the following function:"?


================
Comment at: llvm/test/Transforms/LoopVectorize/scalable-predicate-instruction.ll:13
+; The division should not allow the loop vectorization
+; It can only vectorize when division by zero is garanteed not to happen
+
----------------
nit: Simple typo - it should be `guaranteed`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101916/new/

https://reviews.llvm.org/D101916