[PATCH] D102662: [lld/mac] Correctly set nextdefsym

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: lld/MachO/SyntheticSections.cpp:569-575
+static bool shouldExportExternalSymbol(const Defined *defined) {
   if (defined->privateExtern) {
     assert(defined->isExternal() && "invalid input file");
     return false;
   }
   return true;
 }
----------------
int3 wrote:
> int3 wrote:
> > can we just inline this into a simple check against `defined->privateExtern`? The assert doesn't seem very useful (we already check it once during `InputFile::parseSymbols`)
> (perhaps that change would make more sense as part of D102661)
Done as part of D102661.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102662/new/

https://reviews.llvm.org/D102662