[PATCH] D100845: [Debugify][Original DI] Test preservation of original debug var intrinsics in optimizations

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 18 03:31:37 PDT 2021


djtodoro added a comment.

In D100845#2765535 <https://reviews.llvm.org/D100845#2765535>, @StephenTozer wrote:

> In D100845#2765479 <https://reviews.llvm.org/D100845#2765479>, @StephenTozer wrote:
>
>> LGTM - since this adds new output to debugify I would prefer if there was a review from someone with more authority regarding that sort of thing, but I think this should be harmless: this should only affect original DI preservation checks, since debugify does not add variables and should not be used on modules with existing variables, and I don't believe we depend on debugify's original DI preservation in any tests.
>
> Actually this needs to be corrected, debugify does add variables, but I //believe// that this change isn't going to affect `check-debugify`, is that correct?

This affects `DebugifyMode::OriginalDIMode` only, that checks preservation original debug info (-g generated) in optimizations -- https://llvm.org/docs/HowToUpdateDebugInfo.html#test-original-debug-info-preservation-in-optimizations.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100845/new/

https://reviews.llvm.org/D100845



More information about the llvm-commits mailing list