[PATCH] D102671: [APFloat] convertToDouble/Float can work on shorter types
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 18 03:30:52 PDT 2021
RKSimon added inline comments.
================
Comment at: llvm/unittests/ADT/APFloatTest.cpp:4715
+
+TEST(APFloatTest, ToDouble) {
+ APFloat D1(0.0);
----------------
Maybe break this into shorter tests "HalfToDouble", "BFloatToDouble", "FloatToDouble" etc, to help avoid the variable mismatches noticed by @foad ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102671/new/
https://reviews.llvm.org/D102671
More information about the llvm-commits
mailing list