[PATCH] D102680: [debuginfo-tests] Stop using installed LLDB and remove redundancy

[James Henderson via Phabricator via llvm-commits]

jhenderson created this revision.
jhenderson added reviewers: dblaikie, aprantl, jmorse, StephenTozer, Orlando, jdoerfert, rnk.
jhenderson requested review of this revision.
Herald added a project: LLVM.

The removed code just replicated what use_llvm_tool does, plus looked for an installed LLDB on the PATH to use. In a monorepo world, it seems likely that if people want to run the tests that require LLDB, they should enable and build LLDB itself. If users really want to use the installed LLDB executable, they can specify the path to the executable as an environment variable "LLDB".

See the discussion in https://reviews.llvm.org/D95339#2638619 for more details.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D102680

Files:
  debuginfo-tests/lit.cfg.py


Index: debuginfo-tests/lit.cfg.py
===================================================================
--- debuginfo-tests/lit.cfg.py
+++ debuginfo-tests/lit.cfg.py
@@ -118,12 +118,7 @@
         'debuginfo-tests project.'.format(config.host_triple))
 
 # Check which debuggers are available:
-built_lldb = llvm_config.use_llvm_tool('lldb', search_env='LLDB')
-lldb_path = None
-if built_lldb is not None:
-    lldb_path = built_lldb
-elif lit.util.which('lldb') is not None:
-    lldb_path = lit.util.which('lldb')
+lldb_path = llvm_config.use_llvm_tool('lldb', search_env='LLDB')
 
 if lldb_path is not None:
     config.available_features.add('lldb')


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102680.346089.patch
Type: text/x-patch
Size: 652 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210518/8d9c6646/attachment.bin>