[PATCH] D102260: Update MSVC version number in preprocessor check

[David Spickett via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rGe89b60fcfc7f: Update MSVC version number in preprocessor check (authored by nealsid, committed by DavidSpickett).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102260/new/

https://reviews.llvm.org/D102260

Files:
  llvm/lib/Target/Hexagon/HexagonVectorCombine.cpp


Index: llvm/lib/Target/Hexagon/HexagonVectorCombine.cpp
===================================================================
--- llvm/lib/Target/Hexagon/HexagonVectorCombine.cpp
+++ llvm/lib/Target/Hexagon/HexagonVectorCombine.cpp
@@ -299,9 +299,10 @@
   return getIfUnordered(dyn_cast<StoreInst>(In));
 }
 
-#if !defined(_MSC_VER) || _MSC_VER >= 1924
-// VS2017 has trouble compiling this:
+#if !defined(_MSC_VER) || _MSC_VER >= 1926
+// VS2017 and some versions of VS2019 have trouble compiling this:
 // error C2976: 'std::map': too few template arguments
+// VS 2019 16.x is known to work, except for 16.4/16.5 (MSC_VER 1924/1925)
 template <typename Pred, typename... Ts>
 void erase_if(std::map<Ts...> &map, Pred p)
 #else


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102260.346077.patch
Type: text/x-patch
Size: 728 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210518/8adb4a0f/attachment.bin>