[PATCH] D102558: [Utils] Check for generated functions inline if possible

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 17 18:23:52 PDT 2021


jdoerfert added inline comments.


================
Comment at: clang/test/utils/update_cc_test_checks/Inputs/generated-funcs.c.generated.expected:100
+  }
+}
----------------
ggeorgakoudis wrote:
> The checks for the outlined function are missing?
Good catch. It turns out functions that showed up in line2spell_and_mangled_list multiple times confused the script. I needed to skip duplicates. Fixed now.


================
Comment at: clang/test/utils/update_cc_test_checks/Inputs/lots-of-generated-funcs.c.lots-of-generated.expected:8
+// OMP-NEXT:  entry:
+// OMP-NEXT:    call void (%struct.ident_t*, i32, void (i32*, i32*, ...)*, ...) @__kmpc_fork_call(%struct.ident_t* @[[GLOB1:[0-9]+]], i32 0, void (i32*, i32*, ...)* bitcast (void (i32*, i32*)* @.omp_outlined. to void (i32*, i32*, ...)*))
+// OMP-NEXT:    call void (%struct.ident_t*, i32, void (i32*, i32*, ...)*, ...) @__kmpc_fork_call(%struct.ident_t* @[[GLOB1]], i32 0, void (i32*, i32*, ...)* bitcast (void (i32*, i32*)* @.omp_outlined..1 to void (i32*, i32*, ...)*))
----------------
ggeorgakoudis wrote:
> Checks for .ompu_outlined. are missing
same as above :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102558/new/

https://reviews.llvm.org/D102558



More information about the llvm-commits mailing list