[PATCH] D102436: [lld][WebAssembly] Enable string merging for debug sections

[Derek Schuff via Phabricator via llvm-commits]

dschuff added inline comments.


================
Comment at: lld/wasm/InputChunks.h:144
 
+  /*
   InputSegment(StringRef name, uint32_t alignment, uint32_t flags)
----------------
can this be deleted?


================
Comment at: lld/wasm/InputFiles.cpp:368
+  // have to go on the name alone.
+  return sec.Name.startswith(".debug_str");
+}
----------------
this doesn't include `.debug_line_str`.

Also, I guess the current situation is that we are creating the sections with the flags on the LLVM side, but we don't currently have a way to encode custom section flags?


================
Comment at: lld/wasm/OutputSections.cpp:251
+    // A section should not make it here unless its alive
+    // assert(ms->live);
+
----------------
does this not apply to generic chunks the same way?


================
Comment at: lld/wasm/OutputSections.cpp:256
+          make<SyntheticMergedChunk>(name, 0, WASM_SEG_FLAG_STRINGS);
+      // syn->outputSec = this;
+      newSections.push_back(mergedSection);
----------------
is this needed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102436/new/

https://reviews.llvm.org/D102436