[PATCH] D101977: [OpenMP] Create custom state machines for generic target regions

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 17 16:38:38 PDT 2021


jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:494
+      return false;
+    return ParallelRegions.size() == RHS.ParallelRegions.size();
+  }
----------------
ggeorgakoudis wrote:
> Is equality comparison enough for ParallelRegions or should we change ParallelRegions refer to same function? I guess size equality should be enough since we only add ParallelRegions, but still checking.
I will check the content, it should not matter how we use it but you're right, better to plan for the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101977/new/

https://reviews.llvm.org/D101977



More information about the llvm-commits mailing list