[PATCH] D101588: [M68k] fix -Wdefaulted-function-deleted and -Woverloaded-virtual

Min-Yih Hsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 17 15:21:44 PDT 2021


myhsu added a comment.

In D101588#2764656 <https://reviews.llvm.org/D101588#2764656>, @dblaikie wrote:

> In D101588#2730131 <https://reviews.llvm.org/D101588#2730131>, @dblaikie wrote:
>
>> @myhsu (or someone else with M68k familiarity) - the virtual function fix here is a semantic change (previously whatever was calling the virtual function would not have been getting the implementation it is now getting). Is there any testing that could be added to demonstrate that this semantic change is correct/avoid the regression/test the codepath that is missing coverage?
>
> @myhsu Ping on this question ^

Sorry I missed your previous comment. I will try to add a test accordingly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101588/new/

https://reviews.llvm.org/D101588



More information about the llvm-commits mailing list