[PATCH] D102627: [LTO] Support new PM in ThinLTOCodeGenerator.
Francis Visoiu Mistrih via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 17 14:14:42 PDT 2021
thegameg added inline comments.
================
Comment at: llvm/test/ThinLTO/X86/diagnostic-handler-remarks.ll:23
; YAML1-NEXT: Name: Inlined
-; YAML1-NEXT: Function: main
+; YAML1-NEXT: Function: foo
; YAML1-NEXT: Args:
----------------
fhahn wrote:
> steven_wu wrote:
> > Why this test case needs to be changed for switch PM?
> The new PM does inlining a bit different, that's where the difference comes from I think. Perhaps @thegameg has any additional insight in the test case?
Looks like we went from `foo inlined into main` to `bar inlined into foo`. Maybe we now have two remarks: `bar inlined into foo` + `foo inlined into main`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102627/new/
https://reviews.llvm.org/D102627
More information about the llvm-commits
mailing list