[PATCH] D99024: [OpenMP][OMPIRBuilder] Adding support for `omp atomic`

[Fady Ghanim via Phabricator via llvm-commits]

fghanim marked 8 inline comments as done.
fghanim added inline comments.


================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:2551
+  // 'x' is simply rewritten with some 'expr'.
+  // make monotonic ordering we have different
+  AtomicRMWInst::BinOp AtomicOp = (UpdateExpr ? RMWOp : AtomicRMWInst::Xchg);
----------------
Meinersbur wrote:
> "make monotonic ordering we have different"
> incomplete sentence?
rephrased the comment


================
Comment at: llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp:2295-2306
+  //  for (Instruction &Cur : *EntryBB) {
+  //    if (isa<StoreInst>(Cur)) {
+  //      StoreofAtomic = cast<StoreInst>(&Cur);
+  //      if (StoreofAtomic->getPointerOperand() == XVal)
+  //        continue;
+  //      StoreofAtomic = nullptr;
+  //    }
----------------
Meinersbur wrote:
> Please complete remove commented code.
leftover code removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99024/new/

https://reviews.llvm.org/D99024