[PATCH] D102412: [coro] Preserve scope line for compiler generated functions

Dave Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 17 12:59:18 PDT 2021


kastiglione added inline comments.


================
Comment at: llvm/lib/Transforms/Coroutines/CoroSplit.cpp:861
       if (auto DL = ActiveSuspend->getDebugLoc())
-        SP->setScopeLine(DL->getLine());
+        if (SP->getScopeLine() != 0)
+          SP->setScopeLine(DL->getLine());
----------------
@aprantl do you think it's worth checking flags as well? I noticed in the cases where `ScopeLine` was zero, that flags was `FlagArtificial`. Should this logic check that too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102412/new/

https://reviews.llvm.org/D102412



More information about the llvm-commits mailing list