[PATCH] D102637: [lld][MinGW] Introduce aliases for -Bdynamic and -Bstatic

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.

LGTM

Interesting, I wasn't aware of the others, other than `-static`.

Is this use of `-static` (which I'd presume is in the form of `-Wl,-static`) somewhere in the Qt source/build system itself (which would surprise me as I build Qt quite a lot, but I haven't tested building 6.x with cmake statically), or in a third party build script?



================
Comment at: lld/MinGW/Options.td:117
 def alias_undefined_u: JoinedOrSeparate<["-"], "u">, Alias<undefined>;
+def alias_Bdynamic_dy: Flag<["-"],"dy">,Alias<Bdynamic>;
+def alias_Bdynamic_call_shared: Flag<["-"],"call_shared">,Alias<Bdynamic>;
----------------
Nit: I try to keep these alphabetical, especially as long as the existing ones are. And also, keep spaces after commas.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102637/new/

https://reviews.llvm.org/D102637