[PATCH] D87304: [AttributeFuncs] Consider `align` in `typeIncompatible`

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added inline comments.


================
Comment at: llvm/test/Bitcode/attributes-3.3.ll:105
+define void @f17(i8* align 4 %0)
+; CHECK: define void @f17(i8* align 4 %0)
 {
----------------
jdoerfert wrote:
> dexonsmith wrote:
> > jdoerfert wrote:
> > > fhahn wrote:
> > > > just to clarify, `attributes-3.3.ll.bc` needs to be updated, because it contains bitcode that defines a function with align on a non-pointer argument?
> > > it was updated because of that, yes.
> > Hmm, I'm just seeing this now -- but attributes-3.3.ll.bc should not have been changed. Can that part of the change be reverted? Instead, the bitcode reader should have been adjusted to auto-upgrade the bitcode and strip the align attribute where appropriate.
> > 
> > Note that eventually the problem hit in production and @steven_wu added the bitcode upgrade in https://reviews.llvm.org/D102201. The whole reason we have these bitcode tests is to catch upgrade issues before commit.
> With D102201 landed we can revert attributes-3.3.ll.bc. It makes sense to do it that way.
Huh; it looks like D102201 is insufficient, since it only fixes return types. attributes-3.3.ll.bc from 0a8e12fdbbf54e81954b091ac9fb11cd5f5148e1 has an attribute on parameter.

Would you please add the upgrade for parameters? I'm happy to review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87304/new/

https://reviews.llvm.org/D87304