[PATCH] D102613: ARM: support mandatory tail calls

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 17 11:35:32 PDT 2021


paquette accepted this revision.
paquette added a comment.
This revision is now accepted and ready to land.

This looks really similar to the AArch64 code, so I think it's probably good to go.



================
Comment at: llvm/lib/Target/ARM/ARMFrameLowering.cpp:2354
+    // Bail early if the callee is expected to do the adjustment. If
+    // CalleePopAmount is valid but 0 anyway, Amount will be 0 too so it doesn't
+    // matter if we continue a bit longer.
----------------
Maybe there should be an assert checking that if `CalleePopAmount == 0`, then `Amount == 0`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102613/new/

https://reviews.llvm.org/D102613



More information about the llvm-commits mailing list