[PATCH] D102619: [lld/mac] Honor REFERENCED_DYAMICALLY, set it on __mh_execute_header

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:493-496
     return symtab->addDefined(name, isec->file, isec, value, size,
                               sym.n_desc & N_WEAK_DEF, isPrivateExtern,
-                              sym.n_desc & N_ARM_THUMB_DEF);
+                              sym.n_desc & N_ARM_THUMB_DEF,
+                              sym.n_desc & REFERENCED_DYNAMICALLY);
----------------
thakis wrote:
> int3 wrote:
> > Hmm I wonder if we should have Defined's ctor take in `n_desc` directly and then parses those flags. The list of params is getting a bit unwieldy
> That either splits up the isWeakDefCanBeHidden code a bit awkwardly. Mind if I punt on that for now?
yeah we can figure it out in a future diff


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102619/new/

https://reviews.llvm.org/D102619