[PATCH] D102589: [WebAssembly] Nullify DBG_VALUE_LISTS in DebugValueManager

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 17 09:24:38 PDT 2021


dschuff accepted this revision.
dschuff added a comment.
This revision is now accepted and ready to land.

If I'm understanding this correctly, we only create a WebAssemblyDebugValueManager object when we actually stackify a reg and move the def, correct?
I guess that still ends up invalidating a lot of debug info, since we always run explicit locals. 
In the code you've seen, does the debug info all or mostly consist of DBG_VALUE_LISTs now, or is it still mostly DBG_VALUE, or a mix?
I'm just trying to get a sense for how much of a degradation  in debug info quality we have now.
(Not that we shouldn't do this; clearly this is better than the loop-explosion we have now. I'm just trying to get a sense for how urgent the "real" fix is).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102589/new/

https://reviews.llvm.org/D102589



More information about the llvm-commits mailing list