[PATCH] D102634: Calculate indexes of last child of each DWARF entry once during tryExtractDIEsIfNeeded.

Simon Giesecke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 17 09:14:49 PDT 2021


simon.giesecke added a comment.

One thing I don't know here is whether all relevant uses of `DWARFUnit` will end up iterating the children. If that's not the case, then this be done only optionally. We can't do it on-demand on the first call to getLastChild easily though, because then, e.g. GsymCreator, would need to synchronize accesses from multiple threads. But maybe this could be passed as an option to `tryExtractDIEsIfNeeded`?

If this is worthwhile, a similar thing could be done for the siblings.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102634/new/

https://reviews.llvm.org/D102634



More information about the llvm-commits mailing list