[PATCH] D102619: [lld/mac] Honor REFERENCED_DYAMICALLY, set it on __mh_execute_header

[Nico Weber via Phabricator via llvm-commits]

thakis updated this revision to Diff 345899.
thakis retitled this revision from "[lld/mac] Set REFERENCED_DYAMICALLY on __mh_execute_header" to "[lld/mac] Honor REFERENCED_DYAMICALLY, set it on __mh_execute_header".
thakis added a comment.

handle on arbitrary symbols (via `.desc`, and used in PrettyStackTrace -- but see https://reviews.llvm.org/D27683#2763729 , seems a bit pointless)

This makes the patch quite a bit bigger (see diff to patch set 1) for unclear gain. Maybe we should do patch set 1 and just remove the assert for now? On the other hand, it seems like the correct behavior, so maybe we should just do it. The patch doesn't do this for Common and Absolute symbols; if anyone needs that they can add it themselves.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102619/new/

https://reviews.llvm.org/D102619

Files:
  lld/MachO/Driver.cpp
  lld/MachO/InputFiles.cpp
  lld/MachO/MergedOutputSection.cpp
  lld/MachO/SymbolTable.cpp
  lld/MachO/SymbolTable.h
  lld/MachO/Symbols.h
  lld/MachO/SyntheticSections.cpp
  lld/MachO/UnwindInfoSection.cpp
  lld/test/MachO/referenced-dynamically.s
  lld/test/MachO/stabs.s
  lld/test/MachO/symtab.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102619.345899.patch
Type: text/x-patch
Size: 14180 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210517/921f8878/attachment.bin>